-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the NUMA detection for the smcuda BTL. #12391
Conversation
@bosilca, just curious, is this a bug fix or code cleanup? |
It all started from a discussion on Slack about a warning in the smcuda BTL pointed out by @wenduwan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just 1 minor comment.
2a60a6e
to
c6a2b66
Compare
I tried this patch but still see the warning
|
c6a2b66
to
bb54fbc
Compare
Fixed, please try again. |
@bosilca Thank you. The warning is fixed. Now it revealed something else.
|
Signed-off-by: George Bosilca <[email protected]>
bb54fbc
to
6f35a48
Compare
Thanks @bosilca . I will run some additional tests in the background(I don't expect any issue). Feel free to merge otherwise. |
Code cleanup initiated by a discussion on Slack. If we fail to identify the process NUMA node, or if the process is associated with more than one, print a warning to inform the user about the potential performance implication.